Skip to content

Formatting: Increased size of page content section headings. - #249

Merged
pavlenex merged 1 commit into
BitcoinDesign:masterfrom
Bosch-0:headings
Apr 20, 2021
Merged

pavlenex merged 1 commit into
BitcoinDesign:masterfrom
Bosch-0:headings

Conversation

@Bosch-0

@Bosch-0 Bosch-0 commented Apr 20, 2021

Copy link
Copy Markdown
Collaborator

Increased size of page content section headings. They looked too small before, especially on mobile. Below is before and after for desktop and mobile:

Frame 28

Also added the coming soon pages for onboarding in this PR.

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this one so I can rebase #220 as agreed in #248

@pavlenex
pavlenex merged commit e4f3bbd into BitcoinDesign:master Apr 20, 2021
@pavlenex

Copy link
Copy Markdown
Contributor

@Bosch-0 actually I shouldn't have merged this one probably, because the #220 lists these sections in a different way.

With #249

Screenshot 2021-04-20 at 16 47 32

Witth #220

Screenshot 2021-04-20 at 16 47 40

Which one do we prefer? I kinda prefer concise list vs headings which to some may not be that obvious are clickable. I'll rebase if we agree to go with whatever.

@GBKS

GBKS commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

I have conflicting thoughts. The extended one worked much better with 3-4 lines of text, otherwise it's too airy. However, the bullet list is a bit too condensed. Might be ideal to keep your update and revise the spacing via #231 (which seems to become more urgent as we add more content)?

@pavlenex

Copy link
Copy Markdown
Contributor

Sure thingy, I'll re-base #220 according to #249 and await for #231 later on, good idea.

@Bosch-0

Bosch-0 commented Apr 20, 2021

Copy link
Copy Markdown
Collaborator Author

I'm more in favor of the headings. Agree with GBKS dot points look too condensed. In hierarchical terms using dot points makes it look lower, this list is the main content on this page and should be more prominent as @danielnordh mentioned in the comment link in OP. If we were use dot points here it would make sense to also change all the other section overview lists to this styling to keep consistency.

I agree that the spacing could be decreased above the heading between the break, it should match the spacing between the body text and the break. I didn't touch that part of things in this PR as #231 is addressing that and it isn't a simple fix. We could remove the break and decrease margins to get a style like below:

Frame 31

@danielnordh

Copy link
Copy Markdown
Contributor

The left picture looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants